DP Code - PHP 8.3 upgrade testing

From DPWiki

This page is tracking testing done on Ubuntu 24.04 running PHP 8.3 prior to the PROD upgrade later in 2024. The https://clone.pgdp.org system is running this version of the software and can be used for testing.

We need to go through most of the DProofreaders code (in /c/ and /noncvs/) as well a cursory pass on the forums (/phpBB3/) and wiki (/w/ which is also /wiki/). While we have automated tests for the DProofreader code we know it does not give complete coverage. And while the versions of the phpBB and MediaWiki software in theory support PHP 8.3 it would be good to validate core functionality as well.

How to help

  1. Access https://clone.pgdp.org -- this is a clone of the Test server from a few months ago and your TEST account may work on it already. If not, feel free to create a new one.
  2. Try things! The list below has some things we know we need coverage on, but there are more that aren't listed.
  3. If you encounter problems let us know in #pgdpdev (if you are a member of that channel) or add a note to this page.
  4. Update this page with what you've tested (add your name to one of the existing entries or add a new entry if you tested something that wasn't listed).

Remember:

  • This is a test system and you can't "mess anything up" but it's also a shared system so play nice.
  • Because it's a test system the data is ... interesting and may not be fully consistent. That's not a bug :)
  • We do not need testing on different browsers / devices so don't bother.
  • This clone will be eventually destroyed -- do not save data to this system that you want to keep.

What to look for

Beyond "does it work", be on the watch for any notices, warnings, deprecation errors, or similar messages. Error reporting is cranked up to maximum on clone.pgdp.org to catch these. All of these errors should be logged server-side, so encountering them at all is the important part. When you identify something, please add a note here.

Main site

Accounts

  • Logging in
✅ (srjfoo)
  • Logging out
✅ (srjfoo)
  • Registering & activating an account
    • Registration form
☑️ fixed and re-tested: Registration form: Deprecated: Function strftime().... No problems with the rest of the registration (srjfoo)
  • Registering a new account
✅ (srjfoo)

Overall site navigation

  • Main page
✅ (srjfoo)
    • Search widget in header
✅ (srjfoo)
  • Activity Hub
✅ (srjfoo)
  • Round pages
✅ (srjfoo)
  • My Projects (test all tabs)
✅ (srjfoo)
  • My Suggestions (test all tabs)
✅ (srjfoo)
  • Project Search (test configuring columns)
✅ (srjfoo)
  • Preferences (test all tabs)
✅ (srjfoo)

Quizes

  • Check all of the quizzes (you can cheat!) and tutorials

Proofreading

(all in both the standard and enhanced interfaces)

  • Proofread a page & save it
✅/✅ (srjfoo)(standard/enhanced)
  • WordCheck
✅/✅ (srjfoo)
  • Fix a problem word
✅/✅ (srjfoo)
  • Suggest a word
✅/✅ (srjfoo)
  • Test with different dictionaries
✅/✅ (srjfoo)
  • Tools
  • Search/Replace
✅ (srjfoo)
  • Greek Transliterator
✅ (srjfoo)
  • Hieroglyphs
✅ (srjfoo)
  • Format Preview
✅ (srjfoo)
  • Table Maker
✅ (srjfoo)
  • View Character Suites
✅ (srjfoo)

Statistics

  • Members
    • Searching & viewing
✅ (srjfoo)
  • Teams
    • Searching & viewing
✅ (srjfoo)
    • Adding a team
✅ (srjfoo)
    • Editing a team
✅ (srjfoo)
  • Viewing all of the stat pages
✅ (srjfoo)
When viewing the team stats, things to be aware of:
  • Team pages don't start keeping track of your stats for team purposes until after you join the team.
  • Because the clone was not active between mid-July and the end of August, the 14-day and 30-day stats won't show anything (14-day should in a few days).

Project Management

  • PM page
✅ (theshriek)
  • Creating a project
✅ (theshriek)
  • Editing project information
✅ (theshriek)
  • Editing word lists
    • All of the tools on the editing word lists page
✅ (theshriek)
  • Manage proofreaders' suggestions
✅ (theshriek)
  • Handling bad page
✅ (theshriek)
  • Remote File Manager
✅ (theshriek)
  • Project Quick Check
✅ (theshriek)
  • Show Special Days
✅ (theshriek)
  • Show Image Sources
✅ (theshriek)
  • Show Release Queues
✅ (theshriek)
  • View, add, delete Character Suites
✅ (theshriek)

PP and PPV

  • Check out for PP and upload for PPV
✅ (theshriek)
  • Check out for PPV, generate PPV report
✅ (theshriek)
  • Change project state
✅ (theshriek)
  • Make project available for SR
✅ (theshriek)

Smoooth Reading

  • Download a file
✅ (theshriek)
  • Open text/HTML in browser
✅ (theshriek)
  • Add comments to file and upload
Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /data/htdocs/c/tools/upload_text.php on line 238 (srjfoo)

Site admin

  • User
  • Manage Site Access Privs
✅ (cpeel)
  • Pending Access Requests
✅ (cpeel)
  • Show Access Log
✅ (cpeel)
  • Resend Account Activation Email
✅ (cpeel)
  • Project
  • Copy Pages
✅ (srjfoo)
  • Delete Pages
✅ (srjfoo)
  • Rename Pages
✅ (srjfoo)
  • Jump Project to State
✅ (srjfoo)
  • Regenerate post files
✅ (srjfoo)
  • Convert Project Table to UTF-8
✅ (srjfoo)
  • Data Review
  • Questionable Clearances
✅ (srjfoo)
  • Detect duplicate postednum
✅ (srjfoo)
  • Show common words from project word lists
✅ (srjfoo)
  • Show projects with 'odd' values
✅ (srjfoo)
  • Site
  • Manage Site News
✅ (srjfoo)
  • Manage Random Rules
✅ (srjfoo)
  • Manage Special Days
✅ (srjfoo)
  • Manage Site Character Suites
✅ (srjfoo)
  • Manage Site Word Lists
  • Show Job Log
✅ (srjfoo)
  • Translation Center
✅ (srjfoo)

Background Jobs

  • ArchiveProjects
  • CleanUploadsTrash
✅ (cpeel)
  • ExtendSiteTallyGoals
✅ (cpeel)
  • ImportPGCatalog
✅ (cpeel)
  • NotifyOldPP
✅ (cpeel)
  • PruneJobLogs
  • RecordProjectStateCounts
✅ (cpeel)
  • RecordUserCounts
✅ (cpeel)
  • SendSmoothreadingNotifications
✅ (cpeel)
  • TakeTallySnapshots
✅ (cpeel)
  • ToggleSpecialDayQueues
✅ (cpeel)

Misc

  • Manage Image Sources
✅ (srjfoo)
  • Character Suites, manage
✅ (srjfoo)
  • Authors code (UGH)
✅ (srjfoo) (agreed)
Checks included editing and adding authors and biographies.

ppwb

The ppwb includes PHP code, python code, and golang code. We should confirm that all of the tools in the ppwb continue to work. We don't need to test all options, but at least a run through of each is good.

  • pptext
  • ✅ (srjfoo)
  • pphtml
  • ✅ (srjfoo)
  • ppsmq
  • ✅ (srjfoo)
  • ppcomp
  • ✅ (srjfoo)

Forums

We do not make many changes to the phpBB code and therefore do not need an extensive test pass. This section is both a sanity check and focuses on areas that are unique to how we use / integrate phpBB into the DP code.

  • Logging in
✅ (srjfoo)
  • Posting in a thread
✅ (srjfoo)

Wiki

We do not make changes to the MediaWiki code and therefore do not need an extensive test pass. This section focuses on areas that are unique to how we use or integrate MediaWiki into the DP code.

  • Logging in
✅ (srjfoo)
  • Editing & saving a page
✅ (srjfoo)
  • Checking the DP MediaWiki Extensions
  • dpExtensions
✅ (srjfoo),
All except the %short_state% field, which doesn't appear to exist. (line 133+ in dpExtensions.php. (Note that this is noted here as a reminder; it's not related to the upgrade, but just something that was found that's been there for a long time.)
  • projectHospital
✅ (srjfoo)
Retrieved from "https://www.pgdp.net/w/index.php?title=DP_Code_-_PHP_8.3_upgrade_testing&oldid=132301"